Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Built the latest release tag (
Together with #3987 and #3989 this is what lets iOS move to Qt 6, so an iOS release (3.12.6 or 3.12.7, maintainers' call) depends on it.
|
|
Verified beyond the launch abort: a development-signed build runs on an iPhone 15 Pro (iOS 27.0.1) and in the iPhone 17, iPad Pro and Apple Vision Pro simulators (the iPad build runs in "Designed for iPad" mode on visionOS). Without this change the release tag aborts, as noted above. Not ready for a TestFlight upload yet, independently of this PR:
Separate distribution question: the iOS build statically links Qt 6.11.1 and Qt's FFmpeg, so the LGPL relink obligation needs a decision before a public release.
|
|
On the LGPL thing, I hope we're fine as iOS is special anyway. Also it's already published anyway. the xcprivacy one is nice to have but we already set it manually on AppStore connect. CFBundleShortVersionString = 1.0 and CFBundleVersion = 1 currently manually updated before each release... |
src/ios/ios_app_delegate.mm defines a second QIOSApplicationDelegate which
shadows Qt 6's own implementation. Qt 6 provides the UIScene lifecycle
adoption required since iOS 26; with the duplicate implementation the app
aborts on launch with:
Application failed to launch: UIScene life cycle is required for apps
built with this SDK
(QTBUG/SIGTRAP from -[UIApplication workspace:didCreateScene:...]).
4baa1c9 to
715000e
Compare
|
I'd like to get this into a release for iOS as we need to move to Qt6 asap. Together with the chat window fix, I believe it should be mostly fine. There could still be some minor UI issues e.g. the feedback message but otherwise I suppose we could release iOS on Qt6 on the next release. |
softins
left a comment
There was a problem hiding this comment.
Looks sensible to me. I'll be happy to test it when it is on TestFlight, as I now have an iPad with iPadOS 26.
|
Great. I'd like to have the chat window fix in too. |
|
And it works on my phone too. So hardware is definitely tested. |
…e#3988 combo, grant mic, idb Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01189Juyu5SViHMRVmVATSJv
|
@pljones I tagged it for 3.12.6 as it seems to be a blocker for an app store release of current stable with the Xcode 27 SDK. Qt5 does not work reliably, so we should bump to Qt6. |
|
As I've mentioned before:
(Once the target 3.12 milestone is released, the board view filter and title get bumped.) |
|
Hmm ok. |
Short description of changes
Only compile
src/ios/ios_app_delegate.mmfor Qt 5.That file defines a second
QIOSApplicationDelegate. Qt 6 ships its own implementation, which provides the UIScene lifecycle adoption required since iOS 26; the duplicate definition shadows those methods and the app aborts on launch with:followed by
SIGTRAPin-[UIApplication workspace:didCreateScene:withTransitionContext:completion:]. With the file compiled only for Qt 5 the app launches normally.CHANGELOG: iOS: Fixed the app aborting on launch when built with Qt 6.
Context: Fixes an issue?
Relates to #3406 (Qt 6 iOS compatibility). There is no issue for the abort itself.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Working implementation, verified locally.
What is missing until this pull request can be merged?
Checklist
AUTOBUILD: Please build all targets